Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add account2utxo / utxo2account / account2account dftx #175

Merged
merged 9 commits into from
May 3, 2021
Merged

add account2utxo / utxo2account / account2account dftx #175

merged 9 commits into from
May 3, 2021

Conversation

ivan-zynesis
Copy link
Contributor

What kind of PR is this?:

/kind feature

What this PR does / why we need it:

add DfTx for accountToUtxos / utxosToAccount / accountToAccount

Which issue(s) does this PR fixes?:

Fixes #

Additional comments?:

@ivan-zynesis ivan-zynesis requested a review from fuxingloh as a code owner April 30, 2021 04:43
@ivan-zynesis ivan-zynesis self-assigned this Apr 30, 2021
@github-actions
Copy link

github-actions bot commented Apr 30, 2021 •
edited
Loading

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
packages/jellyfish/dist/jellyfish.umd.js 18.87 KB (0%) 378 ms (0%) 182 ms (-0.65% 🔽) 559 ms

@fuxingloh fuxingloh mentioned this pull request Apr 30, 2021
Closed
17 tasks
@codecov
Copy link

codecov bot commented Apr 30, 2021 •
edited
Loading

Codecov Report

Merging #175 (e859712) into main (a969279) will decrease coverage by 0.27%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #175      +/-   ##
==========================================
- Coverage   95.50%   95.23%   -0.28%     
==========================================
  Files          56       58       +2     
  Lines        1180     1217      +37     
  Branches      149      150       +1     
==========================================
+ Hits         1127     1159      +32     
- Misses         50       55       +5     
  Partials        3        3
Impacted Files Coverage Δ
...ages/jellyfish-transaction/src/script/defi/dftx.ts 93.54% <100.00%> (+0.95%) ⬆️
...lyfish-transaction/src/script/defi/dftx_account.ts 100.00% <100.00%> (ø)
...lyfish-transaction/src/script/defi/dftx_balance.ts 100.00% <100.00%> (ø)
...jellyfish-transaction/src/script/defi/dftx_pool.ts 100.00% <100.00%> (ø)
...ckages/jellyfish-transaction/src/script/mapping.ts 96.96% <100.00%> (+0.41%) ⬆️
packages/testcontainers/src/chains/container.ts 84.54% <100.00%> (-4.03%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c4a076...e859712. Read the comment docs.

@fuxingloh fuxingloh added this to the Jellyfish Wallet milestone Apr 30, 2021
@netlify
Copy link

netlify bot commented May 3, 2021 •
edited
Loading

Deploy preview for jellyfish-defi ready!

Built with commit 276ad5c

https://deploy-preview-175--jellyfish-defi.netlify.app

fuxingloh
fuxingloh requested changes May 3, 2021
View reviewed changes
Copy link
Contributor

@fuxingloh fuxingloh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor code split refactor

packages/jellyfish-transaction/src/script/defi/dftx_balance.ts Show resolved Hide resolved
@fuxingloh fuxingloh merged commit 6c805af into main May 3, 2021
@fuxingloh fuxingloh deleted the feature/dftx_balance branch May 3, 2021 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fuxingloh fuxingloh fuxingloh approved these changes

@canonbrother canonbrother Awaiting requested review from canonbrother

Assignees

@ivan-zynesis ivan-zynesis

Labels
kind/feature New feature request
Projects
None yet
Milestone
Jellyfish Wallet
Development

Successfully merging this pull request may close these issues.
3 participants
@ivan-zynesis @fuxingloh @defichain-bot